Skip to content

RW-12661 Support qiime #4831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

RW-12661 Support qiime #4831

wants to merge 11 commits into from

Conversation

Qi77Qi
Copy link
Collaborator

@Qi77Qi Qi77Qi commented Mar 10, 2025

Have to do this hacky thing because the current way we're installing jupyter server extension assumes we also need to install the package (see this)

This won't work for qiime, because it's not installed via pip.

The other thing is we needed to upgrade jupyter-server in order to enable qimme server extension.

TODO: test

Jira ticket: https://precisionmedicineinitiative.atlassian.net/browse/RW-12661

Summary of changes

What

Why

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.53%. Comparing base (be8c038) to head (e382365).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4831      +/-   ##
===========================================
- Coverage    74.55%   74.53%   -0.03%     
===========================================
  Files          166      166              
  Lines        14633    14633              
  Branches      1164     1164              
===========================================
- Hits         10910    10907       -3     
- Misses        3723     3726       +3     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8c038...e382365. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant